Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Internationalise intcomma and add fr_FR #183

Merged
merged 3 commits into from
Dec 12, 2020
Merged

Internationalise intcomma and add fr_FR #183

merged 3 commits into from
Dec 12, 2020

Conversation

hugovk
Copy link
Collaborator

@hugovk hugovk commented Nov 27, 2020

Fixes #177.

Changes proposed in this pull request:

  • Add internationalisation to intcomma
  • There's a mapping of locales to thousands separators in src/humanize/i18n.py
    • Only fr_FR -> added now, and defaults to ,
    • This may be refactored to another file
  • Also some pre-commit/isort updates

@hugovk hugovk added enhancement New feature or request changelog: Added For new features labels Nov 27, 2020
@hugovk hugovk mentioned this pull request Nov 27, 2020
Closed
@hugovk hugovk merged commit 97fc008 into jmoiron:master Dec 12, 2020
@hugovk hugovk deleted the i18n-intcomma branch December 12, 2020 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
changelog: Added For new features enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

intcomma doesn't support internationalization
1 participant
@hugovk